This repository has been archived by the owner on Aug 3, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
turns out wranglerjs already implements #1219 (correct me if im wrong @xtuc - we call
compiler.watch
when we pass--watch=1
towranglerjs
)the problem was that we would start a wranglerjs process with
--watch=1
at the beginning, but then we'd also run a regular blocking wrangler js build after code was changed. this should speed up live reload by at least 2x...? probably? haven't actually benchmarked but this change should make a noticeable difference.cc @PierBover this is relevant to your interests 😄