Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: set deployment-url for "versions upload" command #348

Conversation

gferreri
Copy link

Fixes #343

Simply extend the check to pull deployment-url from stdout if the command is versions upload.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
update comment
@gferreri gferreri requested review from a team as code owners January 27, 2025 18:55
@NejcZdovc
Copy link

+1 on this one

@Maximo-Guk
Copy link
Member

Maximo-Guk commented Feb 6, 2025

Hey @gferreri , thanks for the PR!

I've opened up another PR which takes a slightly different approach #351. It extracts the preview-url from the OutputEntryVersionUpload that wrangler outputs instead.

This approach should be more stable than parsing it from stdout 🤞

@gferreri
Copy link
Author

gferreri commented Feb 7, 2025

Hey @gferreri , thanks for the PR!

I've opened up another PR which takes a slightly different approach #351. It extracts the preview-url from the OutputEntryVersionUpload that wrangler outputs instead.

This approach should be more stable than parsing it from stdout 🤞

Sounds good. I took the naive approach that simply gets the job done, but if there's a more reliable way to do the same I'm all for it, as long as it gets fixed! 🙂

@gferreri
Copy link
Author

gferreri commented Feb 7, 2025

closing in favor of #351

@gferreri gferreri closed this Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

versions commands do not set deployment-url
3 participants