Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bun support #188

Merged
merged 4 commits into from
Oct 10, 2023
Merged

Conversation

jacobsandersen
Copy link
Contributor

This PR adds Bun support and closes #187.

I wrote the PR before I read the contributing guidelines (sorry) and did not make an issue before I started working. As such, if you decline this it's not a big deal.

However, worth noting, it does work and I can deploy my website to CF pages with this.

@jacobsandersen jacobsandersen requested a review from a team as a code owner October 7, 2023 10:19
@1000hz
Copy link
Contributor

1000hz commented Oct 10, 2023

Hey @simpleauthority! Happy to accept this PR, but I just merged #190 which refactored some of the package manager stuff. Could you please rebase and port your changes over? All of the package manager logic is now in packageManagers.ts.

Also, please run bunx changeset to add a minor version bump. Thanks for opening this PR!

@jacobsandersen
Copy link
Contributor Author

Sure thing, I will take a look.

@jacobsandersen
Copy link
Contributor Author

Rebased, tests all pass, was able to deploy my website with this, and added the changeset. Let me know if you need anything else @1000hz. Thanks!

test/bun/package.json Outdated Show resolved Hide resolved
@1000hz
Copy link
Contributor

1000hz commented Oct 10, 2023

Oh, one more thing I just realized before I merge. Could you add bun as an option to the documentation in action.yml?

@jacobsandersen
Copy link
Contributor Author

Done!

@1000hz 1000hz merged commit 032a724 into cloudflare:main Oct 10, 2023
1 of 3 checks passed
@github-actions github-actions bot mentioned this pull request Oct 10, 2023
@jacobsandersen jacobsandersen deleted the feat/add-bun-support branch October 10, 2023 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add bun support
2 participants