Skip to content

Commit

Permalink
Merge pull request #345 from cloudflare/fix/pages-gh-deployment
Browse files Browse the repository at this point in the history
fix: pages github deployment not triggering due to incorrect condition #2
  • Loading branch information
Maximo-Guk authored Jan 17, 2025
2 parents d5031c3 + e819570 commit fc89533
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 26 deletions.
5 changes: 5 additions & 0 deletions .changeset/tiny-pillows-return.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wrangler-action": patch
---

fix: Pages GitHub Deployment not triggering
3 changes: 1 addition & 2 deletions src/service/github.ts
Original file line number Diff line number Diff line change
Expand Up @@ -92,8 +92,7 @@ export async function createGitHubDeploymentAndJobSummary(
config.GITHUB_TOKEN &&
pagesArtifactFields.production_branch &&
pagesArtifactFields.pages_project &&
pagesArtifactFields.deployment_trigger &&
pagesArtifactFields.stages
pagesArtifactFields.deployment_trigger
) {
const octokit = getOctokit(config.GITHUB_TOKEN);
await Promise.all([
Expand Down
24 changes: 0 additions & 24 deletions src/wranglerArtifactManager.ts
Original file line number Diff line number Diff line change
Expand Up @@ -17,30 +17,6 @@ const OutputEntryPagesDeployment = OutputEntryBase.merge(
// optional, added in [email protected]
production_branch: z.string().optional(),
// optional, added in [email protected]
stages: z
.array(
z.object({
name: z.enum([
"queued",
"initialize",
"clone_repo",
"build",
"deploy",
]),
status: z.enum([
"idle",
"active",
"canceled",
"success",
"failure",
"skipped",
]),
started_on: z.string().nullable(),
ended_on: z.string().nullable(),
}),
)
.optional(),
// optional, added in [email protected]
deployment_trigger: z
.object({
metadata: z.object({
Expand Down

0 comments on commit fc89533

Please sign in to comment.