Skip to content

Commit

Permalink
Merge pull request #193 from cloudflare/cina/fix-packagemanager-default
Browse files Browse the repository at this point in the history
Don't set `packageManager` default via action.yml
  • Loading branch information
1000hz authored Oct 11, 2023
2 parents 0e6f0d3 + bd06b29 commit f40a9f5
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 5 deletions.
5 changes: 5 additions & 0 deletions .changeset/dirty-poets-swim.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"wrangler-action": patch
---

Fixed the package manager not being inferred based on lockfile when the `packageManager` input isn't set.
3 changes: 1 addition & 2 deletions action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,5 @@ inputs:
description: "A string of environment variable names, separated by newlines. These will be bound to your Worker using the values of matching environment variables declared in `env` of this workflow."
required: false
packageManager:
description: "The package manager you'd like to use to install and run wrangler. If not specified, a value will be inferred based on the presence of a lockfile. Valid values: [npm, pnpm, yarn, bun]"
description: "The package manager you'd like to use to install and run wrangler. If not specified, the preferred package manager will be inferred based on the presence of a lockfile or fallback to using npm if no lockfile is found. Valid values are `npm` | `pnpm` | `yarn` | `bun`."
required: false
default: npm
2 changes: 1 addition & 1 deletion src/packageManagers.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ describe("getPackageManager", () => {
}
`);

expect(getPackageManager('bun', { workingDirectory: "test/bun" }))
expect(getPackageManager("bun", { workingDirectory: "test/bun" }))
.toMatchInlineSnapshot(`
{
"exec": "bunx",
Expand Down
2 changes: 1 addition & 1 deletion src/packageManagers.ts
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ const PACKAGE_MANAGERS = {
},
bun: {
install: "bun i",
exec: "bunx"
exec: "bunx",
},
} as const satisfies Readonly<Record<string, PackageManager>>;

Expand Down
2 changes: 1 addition & 1 deletion test/bun/package.json
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
{
"name": "wrangler-action-bun-test",
"name": "wrangler-action-bun-test"
}

0 comments on commit f40a9f5

Please sign in to comment.