-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix D1 Export error handling when presigned URLs are invalid #8131
Conversation
🦋 Changeset detectedLatest commit: 1d3d61c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13387657464/npm-package-wrangler-8131 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/8131/npm-package-wrangler-8131 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13387657464/npm-package-wrangler-8131 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13387657464/npm-package-cloudflare-workers-bindings-extension-8131 -O ./cloudflare-workers-bindings-extension.0.0.0-v0d6afc3cf.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v0d6afc3cf.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13387657464/npm-package-create-cloudflare-8131 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13387657464/npm-package-cloudflare-kv-asset-handler-8131 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13387657464/npm-package-miniflare-8131 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13387657464/npm-package-cloudflare-pages-shared-8131 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13387657464/npm-package-cloudflare-unenv-preset-8131 @cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13387657464/npm-package-cloudflare-vite-plugin-8131 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13387657464/npm-package-cloudflare-vitest-pool-workers-8131 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13387657464/npm-package-cloudflare-workers-editor-shared-8131 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13387657464/npm-package-cloudflare-workers-shared-8131 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/13387657464/npm-package-cloudflare-workflows-shared-8131 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
cde69e8
to
77f77bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
0d39adc
to
1d3d61c
Compare
Fixes error handling for CFSQL-1205 (https://www.cloudflarestatus.com/incidents/x2vwc84qvwx3).
When the presigned URLs generated during export are invalid, wrangler was just outputting the broken response into the SQL file.
This change adds a validation that the request was successful before writing it to the file so that users get immediate feedback that it went wrong. Main change is in
packages/wrangler/src/d1/export.ts
.