Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixtures using startWorker() and Miniflare directly #7802

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

penalosa
Copy link
Contributor

Just adding some additional fixtures to demostrate direct use of the Miniflare API and startWorker() in a non-Vitest testing framework.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: only changes fixtures
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: only changes fixtures

@penalosa penalosa requested a review from a team as a code owner January 16, 2025 20:07
Copy link

changeset-bot bot commented Jan 16, 2025

⚠️ No Changeset found

Latest commit: 5fb4a9a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

});
});

describe("worker build", () => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice PR!

nit: "worker build" and "worker" names in the next file are not very descriptive.

(question: how to use a different worked when interacting with Miniflare? I don't see an option so I guess MINIFLARE_WORKERD_VERSION is respected?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Untriaged
Development

Successfully merging this pull request may close these issues.

2 participants