Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update devtools patches #7693

Merged
merged 3 commits into from
Jan 9, 2025
Merged

chore: update devtools patches #7693

merged 3 commits into from
Jan 9, 2025

Conversation

emily-shen
Copy link
Contributor

@emily-shen emily-shen commented Jan 7, 2025

Quarterly devtools patch updates

Console tab:

  • Logging plain text
  • Logging numbers
  • Maintaining connection across script reloads (i.e. the "Script modified; context reset." message)
  • Logging (explorable) structured data
  • Logging thrown errors
  • Filter by log level
  • Ability to clear logs

Sources tab:

  • View worker source
  • Source updates (after deployed and request sent to edgeworker)
  • Throwing an error correctly underlines the line of code which threw

Network tab:

  • Subrequests are shown
  • Response headers are shown
  • Response bodies are shown
  • "Disable Cache" and "Throttle Network" buttons are hidden

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: manually tested - see above
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: does not affect our e2e flow
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: should have no functionality changes

Copy link

changeset-bot bot commented Jan 7, 2025

🦋 Changeset detected

Latest commit: 2ea689f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/chrome-devtools-patches Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@emily-shen emily-shen added preview:workers-playground Trigger a workers playground preview deploy preview:chrome-devtools-patches Trigger a devtools preview deploy labels Jan 7, 2025
Copy link
Contributor

github-actions bot commented Jan 7, 2025

The Wrangler DevTools preview is now live. You can access it directly at: https://19be0a59.cloudflare-devtools.pages.dev/js_app

In order to test the DevTools preview in wrangler:

  1. npx wrangler dev.
  2. Hit d to open the DevTools in a fresh browser window.
  3. Paste the DevTools preview URL into the address bar (keeping all existing query parameters), e.g:
- https://devtools.devprod.cloudflare.dev/js_app?theme=systemPreferred&ws=127.0.0.1%3A9229%2Fws&domain=tester&debugger=true
+ https://8afc7d3d.cloudflare-devtools.pages.dev/js_app?theme=systemPreferred&ws=127.0.0.1%3A9229%2Fws&domain=tester&debugger=true

The Workers Playground preview is also now live. The Playground preview embeds the above DevTools preview, so you can see them working together at:
https://3a02346b.workers-playground.pages.dev/playground

@emily-shen emily-shen marked this pull request as ready for review January 8, 2025 11:19
@emily-shen emily-shen requested a review from a team as a code owner January 8, 2025 11:19
@@ -28,3 +28,8 @@ cleanup:

test:
git -C devtools-frontend am $(PATCHES)

dev:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the scripts couldn't find the installed tools without setting the path here, so i've added this in and will update the wiki page

@emily-shen emily-shen force-pushed the emily/update-devtools3 branch from 4a900db to 2ce926f Compare January 8, 2025 11:52
Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a changeset, or it won't be released

@emily-shen emily-shen force-pushed the emily/update-devtools3 branch from 2ce926f to b390065 Compare January 9, 2025 09:44
@penalosa penalosa merged commit 65a3e35 into main Jan 9, 2025
29 checks passed
@penalosa penalosa deleted the emily/update-devtools3 branch January 9, 2025 13:16
@workers-devprod workers-devprod mentioned this pull request Jan 9, 2025
@MORTEZAMIRSALI
Copy link

78bdec5

penalosa pushed a commit that referenced this pull request Jan 10, 2025
* update patches

* add "make dev"

* changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
preview:chrome-devtools-patches Trigger a devtools preview deploy preview:workers-playground Trigger a workers playground preview deploy
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants