-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(vitest-pool-workers) Fix support for query params with repeated keys #7668
Conversation
🦋 Changeset detectedLatest commit: 260270b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
9382161
to
260270b
Compare
The change is inspired by |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! This looks great to me. I will run the e2e tests for a sanity check and merge it once everything passes. 👍🏼
Congratulations @romeupalos, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm5l7w3j406680cl5g9otx1zn This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account. |
I think this breaks anyone who's currently doing matching against single query params |
Makes sense 👍🏼 Added tests on #7682 |
Fixes #7667
Support interception of URLs with repeated key/name in its query params. e.g.,
/index.html?a=1&a=2
.