feat(wrangler): Capture Workers with static assets in the telemetry data #7604
Conversation
🦋 Changeset detectedLatest commit: 1c485b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| @@ -111,6 +111,7 @@ export function getMetricsDispatcher(options: MetricsConfigOptions) { | |||
| isPagesCI: isPagesCI(), | |||
| isWorkersCI: isWorkersCI(), | |||
| isInteractive: isInteractive(), | |||
| hasAssets: options.hasAssets ?? false, | |||
There was a problem hiding this comment.
this might be a tad misleading, since if options.hasAssets is undefined, we'll default to false, which might not be entirely true. However, the only use case I can see this happening is for code paths that call the old metrics.sendMetricsEvent(). The new metricsDispatcher will handle this correctly
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12433620427/npm-package-wrangler-7604You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7604/npm-package-wrangler-7604Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12433620427/npm-package-wrangler-7604 dev path/to/script.jsAdditional artifacts:wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12433620427/npm-package-cloudflare-workers-bindings-extension-7604 -O ./cloudflare-workers-bindings-extension.0.0.0-vfe85d746b.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vfe85d746b.vsixnpx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12433620427/npm-package-create-cloudflare-7604 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12433620427/npm-package-cloudflare-kv-asset-handler-7604npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12433620427/npm-package-miniflare-7604npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12433620427/npm-package-cloudflare-pages-shared-7604npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12433620427/npm-package-cloudflare-unenv-preset-7604npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12433620427/npm-package-cloudflare-vitest-pool-workers-7604npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12433620427/npm-package-cloudflare-workers-editor-shared-7604npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12433620427/npm-package-cloudflare-workers-shared-7604npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12433620427/npm-package-cloudflare-workflows-shared-7604Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
…ata (#7604) * feat(wrangler): Capture Workers with static assets in the telemetry data * add changeset
Fixes DEVX-1525
During many Workers+Assets conversations, folks have mentioned that we expect usage for assets in remote mode to be fairly small. We should measure accurately what this number is, as it will be a very helpful data point down the road, when more decisions around remote mode will have to be taken.
This PR adds this kind of insight to our telemetry data, by capturing whether the command running is in the context of a Workers + Assets project.
N.B. With these changes in place we will be capturing the Workers + Assets context for all commands, not just
wrangler dev --remote.