refactor: move projectRoot computation to config validation

[petebacondarwin]

A refactor to move the projectRoot field to config (from entry) so that it can be used more flexibly.

[changeset-bot]

⚠️ No Changeset found

Latest commit: 94bcfcd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12136193054/npm-package-wrangler-7415

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7415/npm-package-wrangler-7415

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12136193054/npm-package-wrangler-7415 dev path/to/script.js

Additional artifacts:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12136193054/npm-package-create-cloudflare-7415 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12136193054/npm-package-cloudflare-kv-asset-handler-7415

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12136193054/npm-package-miniflare-7415

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12136193054/npm-package-cloudflare-pages-shared-7415

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12136193054/npm-package-cloudflare-vitest-pool-workers-7415

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12136193054/npm-package-cloudflare-workers-editor-shared-7415

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12136193054/npm-package-cloudflare-workers-shared-7415

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12136193054/npm-package-cloudflare-workflows-shared-7415

Note that these links will no longer work once the GitHub Actions artifact expires.

---

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	workspace:*	3.20241106.1
workerd	1.20241106.1	1.20241106.1
workerd --version	1.20241106.1	2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[penalosa]

I'm not sure why this isn't a type error, but I think the return value here is used further down, and should probably be changed to config.projectRoot as well:

89: const projectRoot = paths.projectRoot ?? process.cwd();

[petebacondarwin]

Oops I missed that one.
It is not a type error it is just redundant further down.

[penalosa]

Unrelated to this PR, but it looks like these props could do with some cleanup... They seem to take both config.rules and config as separate values?

[petebacondarwin]

So in the call site for versionsUpload() there is rules: getRules(config), which does som additional validation of deprecated rules options. That function is used in various places.

I think that whole function can be removed in Wrangler V4, since the deprecated fields might be removed?