Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove await from user Worker fetch in router-worker #7410

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

WalshyDev
Copy link
Member

Fixes N/A

Stops us waiting on asset Worker to return and escalating the errors upwards. We don't need to do this and it currently skews metrics as well.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: no material change
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no e2e tests
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: no public facing change

@WalshyDev WalshyDev requested review from a team as code owners December 2, 2024 15:45
Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: 15524f8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@cloudflare/workers-shared Patch
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@WillTaylorDev
Copy link
Contributor

WillTaylorDev commented Dec 2, 2024

(Pending changeset)

Edit: LGTM

@WalshyDev WalshyDev force-pushed the walshy/remove-await-from-user-worker-fetch branch from 4f952c8 to 15524f8 Compare December 2, 2024 15:48
Copy link
Contributor

github-actions bot commented Dec 2, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12122927164/npm-package-wrangler-7410

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7410/npm-package-wrangler-7410

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12122927164/npm-package-wrangler-7410 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12122927164/npm-package-create-cloudflare-7410 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12122927164/npm-package-cloudflare-kv-asset-handler-7410
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12122927164/npm-package-miniflare-7410
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12122927164/npm-package-cloudflare-pages-shared-7410
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12122927164/npm-package-cloudflare-vitest-pool-workers-7410
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12122927164/npm-package-cloudflare-workers-editor-shared-7410
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12122927164/npm-package-cloudflare-workers-shared-7410
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12122927164/npm-package-cloudflare-workflows-shared-7410

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.1
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@WalshyDev WalshyDev merged commit 6b21919 into main Dec 2, 2024
30 checks passed
@WalshyDev WalshyDev deleted the walshy/remove-await-from-user-worker-fetch branch December 2, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants