-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update Angular experimental Workers + Assets template #7409
Conversation
🦋 Changeset detectedLatest commit: 33368ea The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123430458/npm-package-wrangler-7409 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7409/npm-package-wrangler-7409 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123430458/npm-package-wrangler-7409 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123430458/npm-package-create-cloudflare-7409 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123430458/npm-package-cloudflare-kv-asset-handler-7409 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123430458/npm-package-miniflare-7409 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123430458/npm-package-cloudflare-pages-shared-7409 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123430458/npm-package-cloudflare-vitest-pool-workers-7409 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123430458/npm-package-cloudflare-workers-editor-shared-7409 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123430458/npm-package-cloudflare-workers-shared-7409 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123430458/npm-package-cloudflare-workflows-shared-7409 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
@@ -74,6 +189,80 @@ function getFrameworkTests(opts: { | |||
}, | |||
unsupportedOSs: ["win32"], | |||
}, | |||
nuxt: { | |||
quarantine: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just double checking, is this still supposed to quarantined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It fails in this PR - but then passes in after the Nuxt PR 😄
}, | ||
], | ||
testCommitMessage: true, | ||
unsupportedOSs: ["win32"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just noticed no windows tests actually end up running 🤣 only gatsby supports windows, but we run pnpm for the windows test and gatsby doesn't support that. not sure if worth changing that the windows PM to npm or something.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should tidy that up as a follow up
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixes #0000
fix: update Angular experimental Workers + Assets template