Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update Angular experimental Workers + Assets template #7409

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

petebacondarwin
Copy link
Contributor

Fixes #0000

fix: update Angular experimental Workers + Assets template


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: C3 e2e tests run automatically
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: patch fix

@petebacondarwin petebacondarwin requested review from a team as code owners December 2, 2024 13:50
Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: 33368ea

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@petebacondarwin petebacondarwin changed the title Fix-angular-experimental-template fix: update Angular experimental Workers + Assets template Dec 2, 2024
Copy link
Contributor

github-actions bot commented Dec 2, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123430458/npm-package-wrangler-7409

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7409/npm-package-wrangler-7409

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123430458/npm-package-wrangler-7409 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123430458/npm-package-create-cloudflare-7409 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123430458/npm-package-cloudflare-kv-asset-handler-7409
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123430458/npm-package-miniflare-7409
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123430458/npm-package-cloudflare-pages-shared-7409
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123430458/npm-package-cloudflare-vitest-pool-workers-7409
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123430458/npm-package-cloudflare-workers-editor-shared-7409
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123430458/npm-package-cloudflare-workers-shared-7409
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123430458/npm-package-cloudflare-workflows-shared-7409

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.1
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@@ -74,6 +189,80 @@ function getFrameworkTests(opts: {
},
unsupportedOSs: ["win32"],
},
nuxt: {
quarantine: true,
Copy link
Contributor

@emily-shen emily-shen Dec 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just double checking, is this still supposed to quarantined?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fails in this PR - but then passes in after the Nuxt PR 😄

},
],
testCommitMessage: true,
unsupportedOSs: ["win32"],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just noticed no windows tests actually end up running 🤣 only gatsby supports windows, but we run pnpm for the windows test and gatsby doesn't support that. not sure if worth changing that the windows PM to npm or something.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should tidy that up as a follow up

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petebacondarwin petebacondarwin merged commit 5739015 into main Dec 2, 2024
29 of 30 checks passed
@petebacondarwin petebacondarwin deleted the fix-angular-experimental-template branch December 2, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants