Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update queues max_batch_timeout in miniflare #7399

Merged
merged 4 commits into from
Dec 2, 2024

Conversation

emily-shen
Copy link
Contributor

@emily-shen emily-shen commented Dec 2, 2024

Fixes #7398

max_batch_timeout seems to have been increased (30s -> 60s), updating miniflare validation schema to match.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: unit tests should be ok
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: documentation already showed limit is 60s now 🫠

@emily-shen emily-shen requested a review from a team as a code owner December 2, 2024 10:53
Copy link

changeset-bot bot commented Dec 2, 2024

🦋 Changeset detected

Latest commit: 586c396

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
miniflare Patch
@cloudflare/pages-shared Patch
@cloudflare/vitest-pool-workers Patch
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 2, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123360724/npm-package-wrangler-7399

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7399/npm-package-wrangler-7399

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123360724/npm-package-wrangler-7399 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123360724/npm-package-create-cloudflare-7399 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123360724/npm-package-cloudflare-kv-asset-handler-7399
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123360724/npm-package-miniflare-7399
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123360724/npm-package-cloudflare-pages-shared-7399
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123360724/npm-package-cloudflare-vitest-pool-workers-7399
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123360724/npm-package-cloudflare-workers-editor-shared-7399
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123360724/npm-package-cloudflare-workers-shared-7399
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12123360724/npm-package-cloudflare-workflows-shared-7399

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.1
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@emily-shen emily-shen marked this pull request as draft December 2, 2024 14:54
@emily-shen emily-shen marked this pull request as ready for review December 2, 2024 15:55
Co-authored-by: Carmen Popoviciu <[email protected]>
@emily-shen emily-shen merged commit b3d2e7d into main Dec 2, 2024
30 checks passed
@emily-shen emily-shen deleted the emily/queues-max-batch-timeout branch December 2, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🐛 BUG: max_batch_timeout is limited to 30 seconds in miniflare
2 participants