-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup workers-shared
types
#7304
base: main
Are you sure you want to change the base?
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12072718352/npm-package-wrangler-7304 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7304/npm-package-wrangler-7304 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12072718352/npm-package-wrangler-7304 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12072718352/npm-package-create-cloudflare-7304 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12072718352/npm-package-cloudflare-kv-asset-handler-7304 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12072718352/npm-package-miniflare-7304 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12072718352/npm-package-cloudflare-pages-shared-7304 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12072718352/npm-package-cloudflare-vitest-pool-workers-7304 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12072718352/npm-package-cloudflare-workers-editor-shared-7304 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12072718352/npm-package-cloudflare-workers-shared-7304 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12072718352/npm-package-cloudflare-workflows-shared-7304 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Cleanup
@cloudflare/workers-shared
to ensure that workers, tests, and scripts are typed in the appropriate environment, as well as ensuring that Vitest Pool Workers is used for all the relevant tests. Additionally, move the tests from the asset-config fixture into the asset-worker tests folder.