Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup workers-shared types #7304

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from
Draft

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Nov 20, 2024

Cleanup @cloudflare/workers-shared to ensure that workers, tests, and scripts are typed in the appropriate environment, as well as ensuring that Vitest Pool Workers is used for all the relevant tests. Additionally, move the tests from the asset-config fixture into the asset-worker tests folder.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal refactoring

Copy link

changeset-bot bot commented Nov 20, 2024

⚠️ No Changeset found

Latest commit: 974e435

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 20, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12072718352/npm-package-wrangler-7304

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7304/npm-package-wrangler-7304

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12072718352/npm-package-wrangler-7304 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12072718352/npm-package-create-cloudflare-7304 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12072718352/npm-package-cloudflare-kv-asset-handler-7304
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12072718352/npm-package-miniflare-7304
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12072718352/npm-package-cloudflare-pages-shared-7304
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12072718352/npm-package-cloudflare-vitest-pool-workers-7304
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12072718352/npm-package-cloudflare-workers-editor-shared-7304
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12072718352/npm-package-cloudflare-workers-shared-7304
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12072718352/npm-package-cloudflare-workflows-shared-7304

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.1
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@penalosa penalosa added the e2e Run e2e tests on a PR label Nov 20, 2024
@penalosa penalosa marked this pull request as ready for review November 20, 2024 19:19
@penalosa penalosa requested review from a team as code owners November 20, 2024 19:19
@penalosa penalosa marked this pull request as draft December 2, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR no-changeset-required
Projects
Status: Approved
Development

Successfully merging this pull request may close these issues.

2 participants