Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change wrangler-devtools name to chrome-devtools-patches #7258

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

andyjessop
Copy link
Contributor

@andyjessop andyjessop commented Nov 14, 2024

Fixes #4314.

This renames wrangler-devtools to chrome-devtools-patches universally.

Some other things to do post-merge:

  • change the label name from preview:wrangler-devtools to preview:chrome-devtools-patches
  • update references to wrangler-devtools in Wiki and other documentation

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: doesn't change any logic
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: doesn't change any logic
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal only

@andyjessop andyjessop requested review from a team as code owners November 14, 2024 15:09
Copy link

changeset-bot bot commented Nov 14, 2024

🦋 Changeset detected

Latest commit: 98f42ef

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/chrome-devtools-patches Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 14, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11914952826/npm-package-wrangler-7258

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7258/npm-package-wrangler-7258

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11914952826/npm-package-wrangler-7258 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11914952826/npm-package-create-cloudflare-7258 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11914952826/npm-package-cloudflare-kv-asset-handler-7258
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11914952826/npm-package-miniflare-7258
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11914952826/npm-package-cloudflare-pages-shared-7258
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11914952826/npm-package-cloudflare-vitest-pool-workers-7258
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11914952826/npm-package-cloudflare-workers-editor-shared-7258
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11914952826/npm-package-cloudflare-workers-shared-7258
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11914952826/npm-package-cloudflare-workflows-shared-7258

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241106.0
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@emily-shen emily-shen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved pending an update to the snapsnot in the tools test 🚀

chore: add changeset

chore: update lock file

chore: update formatting

chore: fix snapshot tests
@andyjessop andyjessop force-pushed the aj/change-wrangler-devtools-name branch from 2894772 to 98f42ef Compare November 19, 2024 14:17
@andyjessop andyjessop merged commit f1f508e into main Nov 19, 2024
30 checks passed
@andyjessop andyjessop deleted the aj/change-wrangler-devtools-name branch November 19, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Rename wrangler-devtools package
4 participants