-
Notifications
You must be signed in to change notification settings - Fork 741
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add additional fields to pages deploy detailed artifact #7252
Add additional fields to pages deploy detailed artifact #7252
Conversation
🦋 Changeset detectedLatest commit: d5c37f9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11918634505/npm-package-wrangler-7252 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7252/npm-package-wrangler-7252 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11918634505/npm-package-wrangler-7252 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11918634505/npm-package-create-cloudflare-7252 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11918634505/npm-package-cloudflare-kv-asset-handler-7252 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11918634505/npm-package-miniflare-7252 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11918634505/npm-package-cloudflare-pages-shared-7252 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11918634505/npm-package-cloudflare-vitest-pool-workers-7252 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11918634505/npm-package-cloudflare-workers-editor-shared-7252 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11918634505/npm-package-cloudflare-workers-shared-7252 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11918634505/npm-package-cloudflare-workflows-shared-7252 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
1ece459
to
bc286bd
Compare
828e195
to
35ba429
Compare
70fadc2
to
1cf78d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops sorry didn't realise tests were still failing 🫥
a671190
to
ca6a7d3
Compare
1a55e30
to
d5c37f9
Compare
…ngler-action pages parity
d5c37f9
to
36cb0ef
Compare
deployment_trigger: { | ||
metadata: { | ||
commit_hash: | ||
deploymentResponse.deployment_trigger?.metadata?.commit_hash ?? "", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Under what circumstances would deployment_trigger
ever be undefined?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure, it's not a required field in our openapi schema https://developers.cloudflare.com/api/operations/pages-deployment-create-deployment
Also we handle undefined case here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Pages Direct Upload deployments, I believe the git ref is optional because you could deploy a Pages project that is not in a repo
Fixes #7262
Include the
production_branch
anddeployment_trigger
from wrangler pages deploy in Wrangler's pages deploy detailed artifact file.