Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[R2] Output suggested wrangler.toml changes after creating a bucket #7193

Merged
merged 1 commit into from
Nov 7, 2024

Conversation

sdnts
Copy link
Contributor

@sdnts sdnts commented Nov 7, 2024

Fixes R2-000


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: this is an output-only change
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: this is an output-only change

@sdnts sdnts requested a review from a team as a code owner November 7, 2024 15:45
Copy link

changeset-bot bot commented Nov 7, 2024

🦋 Changeset detected

Latest commit: c628c9a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 7, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11728435956/npm-package-wrangler-7193

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7193/npm-package-wrangler-7193

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11728435956/npm-package-wrangler-7193 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11728435956/npm-package-create-cloudflare-7193 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11728435956/npm-package-cloudflare-kv-asset-handler-7193
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11728435956/npm-package-miniflare-7193
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11728435956/npm-package-cloudflare-pages-shared-7193
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11728435956/npm-package-cloudflare-vitest-pool-workers-7193
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11728435956/npm-package-cloudflare-workers-editor-shared-7193
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11728435956/npm-package-cloudflare-workers-shared-7193
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11728435956/npm-package-cloudflare-workflows-shared-7193

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241022.0
workerd 1.20241106.1 1.20241106.1
workerd --version 1.20241106.1 2024-11-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@sdnts sdnts force-pushed the siddhant/r2-create-hint branch from d5b63b1 to ca6760f Compare November 7, 2024 15:49
@sdnts sdnts changed the title improve(wrangler): [R2] Output suggested wrangler.toml changes after creating a bucket [R2] Output suggested wrangler.toml changes after creating a bucket Nov 7, 2024
@sdnts sdnts force-pushed the siddhant/r2-create-hint branch from ca6760f to c628c9a Compare November 7, 2024 17:45
@CarmenPopoviciu CarmenPopoviciu merged commit ad51d1d into cloudflare:main Nov 7, 2024
17 checks passed
@workers-devprod workers-devprod mentioned this pull request Nov 7, 2024
@sdnts sdnts deleted the siddhant/r2-create-hint branch November 7, 2024 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants