-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try and ensure the d.ts
types are definitely the ones loaded in quick-edit-extension
#7040
Conversation
🦋 Changeset detectedLatest commit: 3762311 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11441903078/npm-package-wrangler-7040 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7040/npm-package-wrangler-7040 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11441903078/npm-package-wrangler-7040 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11441903078/npm-package-create-cloudflare-7040 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11441903078/npm-package-cloudflare-kv-asset-handler-7040 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11441903078/npm-package-miniflare-7040 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11441903078/npm-package-cloudflare-pages-shared-7040 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11441903078/npm-package-cloudflare-vitest-pool-workers-7040 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11441903078/npm-package-cloudflare-workers-editor-shared-7040 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11441903078/npm-package-cloudflare-workers-shared-7040 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Make sure we're loading the .d.ts and not the .ts version of the types. Occasionally the wrong version has been loaded in CI, causing spurious typing errors for users in the playground & quick edit. This PR simplifies the loading, and adds an assertion to make sure builds will fail if the wrong version is loaded.