Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create-cloudflare: replace create-svelte with sv #7031

Merged
merged 8 commits into from
Oct 25, 2024

Conversation

codenoid
Copy link
Contributor

@codenoid codenoid commented Oct 21, 2024

What this PR solves / how to test

create-svelte is soon to be deprecated

Fixes #[insert GH or internal issue number(s)].

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: existing test is compatible
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: no related existing documentation on the replaced package

@codenoid codenoid requested review from a team as code owners October 21, 2024 04:07
Copy link

changeset-bot bot commented Oct 21, 2024

🦋 Changeset detected

Latest commit: f5159eb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 23, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11517178652/npm-package-wrangler-7031

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7031/npm-package-wrangler-7031

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11517178652/npm-package-wrangler-7031 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11517178652/npm-package-create-cloudflare-7031 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11517178652/npm-package-cloudflare-kv-asset-handler-7031
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11517178652/npm-package-miniflare-7031
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11517178652/npm-package-cloudflare-pages-shared-7031
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11517178652/npm-package-cloudflare-vitest-pool-workers-7031
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11517178652/npm-package-cloudflare-workers-editor-shared-7031
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11517178652/npm-package-cloudflare-workers-shared-7031
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11517178652/npm-package-cloudflare-workflows-shared-7031

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241022.0
workerd 1.20241022.0 1.20241022.0
workerd --version 1.20241022.0 2024-10-22

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@codenoid
Copy link
Contributor Author

codenoid commented Oct 24, 2024

tested on my local, please review

image

@emily-shen
Copy link
Contributor

hey thanks for opening this PR :)
I'm running our e2e's for you here, since they can't be run from a fork: #7088

I think they're probably going to need updating - since running e2e's locally is a faff, I'm happy to make those changes and push to this branch if that's okay with you?

Once e2e's are sorted, this looks good to me - thanks again!

@codenoid
Copy link
Contributor Author

yes please @emily-shen

@codenoid
Copy link
Contributor Author

image

svelte e2e is now passed

@emily-shen emily-shen merged commit eec2a70 into cloudflare:main Oct 25, 2024
20 of 22 checks passed
@workers-devprod workers-devprod added the contribution [Holopin] Recognizes an open-source contribution, big or small label Oct 25, 2024
Copy link

holopin-bot bot commented Oct 25, 2024

Congratulations @codenoid, the maintainer of this repository has issued you a holobyte! Here it is: https://holopin.io/holobyte/cm2op15au167800ckxja29q8t7

This badge can only be claimed by you, so make sure that your GitHub account is linked to your Holopin account. You can manage those preferences here: https://holopin.io/account.
Or if you're new to Holopin, you can simply sign up with GitHub, which will do the trick!

@emily-shen
Copy link
Contributor

For posterity, c3 e2e's were passing with the linked branch #7088, didn't realise closing that PR would remove the actions whoops 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution [Holopin] Recognizes an open-source contribution, big or small
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants