-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: quarantine C3 analog e2e tests #6995
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11364137403/npm-package-wrangler-6995 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6995/npm-package-wrangler-6995 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11364137403/npm-package-wrangler-6995 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11364137403/npm-package-create-cloudflare-6995 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11364137403/npm-package-cloudflare-kv-asset-handler-6995 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11364137403/npm-package-miniflare-6995 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11364137403/npm-package-cloudflare-pages-shared-6995 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11364137403/npm-package-cloudflare-vitest-pool-workers-6995 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11364137403/npm-package-cloudflare-workers-editor-shared-6995 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11364137403/npm-package-cloudflare-workers-shared-6995 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
cc// @brandonroberts FYI please let me know if any of the above is unclear, or if you have any questions. Also do let me know if there is anything I can support you with, assuming this is smth that can be fixed on the |
Thanks for the heads up @CarmenPopoviciu. Is C3 using the |
thank you so much @brandonroberts Kepp me posted please if you find anything, or if I can action anything on our side |
What this PR solves / how to test
This PR quarantines the C3
analog
e2e tests, which started failing since yesterday. After thoroughly debugging together with Pete, we concluded that the breakage is not caused by one particular change inworkers-sdk
, but rather due to some changes inanalog
itself. Specifically, the breakage seems to come from the latest release of analog, akav 1.9.0
. Currently C3 has a dependency on analog^1.8.0
, which ends up pulling1.9.0
, and results in the failures we're seeing. We attempted to fix the version number of our dependency to1.8.0
, but unfortunately that still end up pulling1.9.0
, due to how analog internally declares its dependencies. This is something we don't have control over, which is why we ultimately decided to quarantine these tests.We also attempted to fix forward, based off of #6975, that bumps
create-analog
to1.9.0
, but unfortunately that broke other things, so here we are.These tests should be quarantined until we are either able to successfully bump
create-analog
to1.9.0
, or until a downstream fix comes from the analog team <3Fixes N/A.
Author has addressed the following