fix assets + custom build = infinite loop

[RamIdeas]

What this PR solves / how to test

Fixes #6876

Previously, if a build.custom command output files into the assets.directory, it caused the command to run again in an infinite loop.

This was caused by the assets watcher in the ConfigController to trigger a configUpdate event – with the intention of triggering a runtime reload – which caused the BundleController to trigger a full build.

The assets watcher has now been moved to the BundleController and triggers a bundleCompleted event instead – with the intention of triggering a runtime reload where Miniflare itself reads the new assets from the filesystem.

Author has addressed the following

• Tests
  • TODO (before merge)
  • Tests included
  • Tests not necessary because:
• E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
  • I don't know
  • Required
  • Not required because:
• Changeset (Changeset guidelines)
  • TODO (before merge)
  • Changeset included
  • Changeset not necessary because:
• Public documentation
  • TODO (before merge)
  • Cloudflare docs PR(s):
  • Documentation not necessary because: bug fix

[changeset-bot]

🦋 Changeset detected

Latest commit: 451510c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
wrangler	Patch
@cloudflare/vitest-pool-workers	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11161082317/npm-package-wrangler-6881

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6881/npm-package-wrangler-6881

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11161082317/npm-package-wrangler-6881 dev path/to/script.js

Additional artifacts:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11161082317/npm-package-create-cloudflare-6881 --no-auto-update

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11161082317/npm-package-cloudflare-kv-asset-handler-6881

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11161082317/npm-package-miniflare-6881

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11161082317/npm-package-cloudflare-pages-shared-6881

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11161082317/npm-package-cloudflare-vitest-pool-workers-6881

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11161082317/npm-package-cloudflare-workers-editor-shared-6881

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11161082317/npm-package-cloudflare-workers-shared-6881

Note that these links will no longer work once the GitHub Actions artifact expires.

---

[email protected] includes the following runtime dependencies:

Package	Constraint	Resolved
miniflare	workspace:*	3.20240925.0
workerd	1.20240925.0	1.20240925.0
workerd --version	1.20240925.0	2024-09-25

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

[zwily]

I tried this out... I updated my test app to point to this PR build:

https://github.com/zwily/remix-wrangler-much-restarting

(Note that I did have to set assets.watch_dir - without that, wrangler never reloaded.)

Now when I run npm run dev and then edit a file, it does not result in infinite rebuilds. However, HMR appears to be broken. Whenever I change a file it rebuilds, and wrangler reloads, but the browser never updates until I force a refresh.

[RamIdeas]

I tried this out... I updated my test app to point to this PR build:

https://github.com/zwily/remix-wrangler-much-restarting

(Note that I did have to set assets.watch_dir - without that, wrangler never reloaded.)

Now when I run npm run dev and then edit a file, it does not result in infinite rebuilds. However, HMR appears to be broken. Whenever I change a file it rebuilds, and wrangler reloads, but the browser never updates until I force a refresh.

I think you're looking for the --live-reload flag. We don't support HMR yet – instead we restart your worker upon changes, but this is different from live reload where we tell the browser something changed and trigger a page reload.

[emily-shen]

thanks for fixing this!

[RamIdeas]

Can't get the Windows tests to begin and want this fix in today's release which will run them anyway

Going to skip the last job and merge anyway