Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve static asset upload messaging #6838

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

GregBrimble
Copy link
Contributor

@GregBrimble GregBrimble commented Sep 26, 2024

What this PR solves / how to test

Fixes N/A

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no coverage
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: tiny fix

@GregBrimble GregBrimble requested a review from a team as a code owner September 26, 2024 14:01
Copy link

changeset-bot bot commented Sep 26, 2024

🦋 Changeset detected

Latest commit: 5eb49bf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod workers-devprod added the e2e Run wrangler e2e tests on a PR label Sep 26, 2024
Copy link
Contributor

@irvinebroque irvinebroque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice one

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11053858429/npm-package-wrangler-6838

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6838/npm-package-wrangler-6838

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11053858429/npm-package-wrangler-6838 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11053858429/npm-package-create-cloudflare-6838 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11053858429/npm-package-cloudflare-kv-asset-handler-6838
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11053858429/npm-package-miniflare-6838
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11053858429/npm-package-cloudflare-pages-shared-6838
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11053858429/npm-package-cloudflare-vitest-pool-workers-6838
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11053858429/npm-package-cloudflare-workers-editor-shared-6838
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11053858429/npm-package-cloudflare-workers-shared-6838

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240925.0
workerd 1.20240925.0 1.20240925.0
workerd --version 1.20240925.0 2024-09-25

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@emily-shen emily-shen added the skip-pr-description-validation Skip validation of the required PR description format label Sep 26, 2024
@emily-shen emily-shen merged commit 7dbd0c8 into main Oct 3, 2024
34 of 38 checks passed
@emily-shen emily-shen deleted the improve-static-asset-messaging branch October 3, 2024 10:45
@workers-devprod workers-devprod mentioned this pull request Oct 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run wrangler e2e tests on a PR skip-pr-description-validation Skip validation of the required PR description format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants