Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix version preview url snapshot #6833

Merged
merged 1 commit into from
Sep 26, 2024
Merged

fix version preview url snapshot #6833

merged 1 commit into from
Sep 26, 2024

Conversation

RamIdeas
Copy link
Contributor

@RamIdeas RamIdeas commented Sep 26, 2024

What this PR solves / how to test

Fixes mismatched snapshots

Version Preview URLs are now enabled. Wrangler already has code to print them to stdout if the property is on the api response. This PR simply updates our snapshots with their normalised form

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because: snapshot update
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: snapshot update

@RamIdeas RamIdeas requested a review from a team as a code owner September 26, 2024 11:00
Copy link

changeset-bot bot commented Sep 26, 2024

⚠️ No Changeset found

Latest commit: 2e34b5c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@workers-devprod workers-devprod added the e2e Run e2e tests on a PR label Sep 26, 2024
Copy link
Contributor

github-actions bot commented Sep 26, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11050961414/npm-package-wrangler-6833

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6833/npm-package-wrangler-6833

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11050961414/npm-package-wrangler-6833 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11050961414/npm-package-create-cloudflare-6833 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11050961414/npm-package-cloudflare-kv-asset-handler-6833
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11050961414/npm-package-miniflare-6833
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11050961414/npm-package-cloudflare-pages-shared-6833
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11050961414/npm-package-cloudflare-vitest-pool-workers-6833
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11050961414/npm-package-cloudflare-workers-editor-shared-6833
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11050961414/npm-package-cloudflare-workers-shared-6833

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240925.0
workerd 1.20240925.0 1.20240925.0
workerd --version 1.20240925.0 2024-09-25

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@RamIdeas RamIdeas force-pushed the e2e-version-preview-url branch from 792055d to 2e34b5c Compare September 26, 2024 11:05
@RamIdeas RamIdeas added the skip-pr-description-validation Skip validation of the required PR description format label Sep 26, 2024
@RamIdeas RamIdeas merged commit 2384560 into main Sep 26, 2024
27 of 32 checks passed
@RamIdeas RamIdeas deleted the e2e-version-preview-url branch September 26, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR skip-pr-description-validation Skip validation of the required PR description format
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants