Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[draft] Wrangler Resource provisioning #6462

Closed
wants to merge 3 commits into from

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Aug 9, 2024

What this PR solves / how to test

This is a draft PR demonstrating a possible way to do resource provisioning with Wrangler. It currently supports R2, KV, and D1. All you need to do is run wrangler deploy against a wrangler.toml file with the ID information missing (namespace_id/bucket_name/database_id) and Wrangler will prompt to create the resource during the deploy. Wrangler will use an inherit binding if the resource already exists, to get around the lack of ID information being persisted.
Screenshot 2024-08-09 at 20 40 56
Screenshot 2024-08-09 at 20 41 52

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because:

@penalosa penalosa requested review from a team as code owners August 9, 2024 19:39
Copy link

changeset-bot bot commented Aug 9, 2024

⚠️ No Changeset found

Latest commit: 1acbf52

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@penalosa penalosa marked this pull request as draft August 9, 2024 19:39
Copy link
Contributor

github-actions bot commented Aug 9, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10324905554/npm-package-wrangler-6462

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6462/npm-package-wrangler-6462

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10324905554/npm-package-wrangler-6462 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10324905554/npm-package-create-cloudflare-6462 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10324905554/npm-package-cloudflare-kv-asset-handler-6462
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10324905554/npm-package-miniflare-6462
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10324905554/npm-package-cloudflare-pages-shared-6462
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10324905554/npm-package-cloudflare-vitest-pool-workers-6462
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10324905554/npm-package-cloudflare-workers-editor-shared-6462
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10324905554/npm-package-cloudflare-workers-shared-6462

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240806.0
workerd 1.20240806.0 1.20240806.0
workerd --version 1.20240806.0 2024-08-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@threepointone
Copy link
Contributor

Can I connect to an existing resource? That'll be a common usecase for d1/kv

@penalosa
Copy link
Contributor Author

Obsoleted by #6600

@penalosa penalosa closed this Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants