-
Notifications
You must be signed in to change notification settings - Fork 778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update C3 OpenAPI template to allow users to pick either Hono or itty-router #6106
Update C3 OpenAPI template to allow users to pick either Hono or itty-router #6106
Conversation
🦋 Changeset detectedLatest commit: c7f9794 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
4fe29dc
to
34d5888
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9804221077/npm-package-wrangler-6106 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6106/npm-package-wrangler-6106 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9804221077/npm-package-wrangler-6106 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9804221077/npm-package-create-cloudflare-6106 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9804221077/npm-package-cloudflare-kv-asset-handler-6106 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9804221077/npm-package-miniflare-6106 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9804221077/npm-package-cloudflare-pages-shared-6106 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/9804221077/npm-package-cloudflare-vitest-pool-workers-6106 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
e86eed6
to
601ec03
Compare
Builds are failing because the PR is done from a forked repo, but should otherwise be green |
d2f3439
to
c533a49
Compare
I've updated the pull request, to allow users to pick either Hono or itty-router as the base framework for this c3 template. |
3d1937d
to
957df44
Compare
}, | ||
"dependencies": { | ||
"@cloudflare/itty-router-openapi": "^1.0.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this really needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this old dependency needs to be removed
47de9f1
to
a4764fb
Compare
Hey @jculvey , the C3 E2E builds are failing for reasons not related to this pr, do you think you could merge this? |
a4764fb
to
c7f9794
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed this branch to our fork to run the e2e tests. See #6207.
They are now green.
What this PR solves / how to test
This pr updates the C3 OpenAPI template to allow users to pick either Hono or itty-router.
Example usage:
npm create cloudflare@latest -- --type openapi --framework hono
npm create cloudflare@latest -- --type openapi --framework itty-router
Author has addressed the following