queue consumer setting max_batch_timeout, batch-timeout should accept 0 #5859
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test
Fixes MQ-635
The setting for a queue consumer's batch-timeout should accept 0 as a valid value. This PR fixes a bug where
0
was being treated as falsy and sending the backend request with the value omitted.For example:
queues consumer add testQueue testScript --env myEnv --batch-size 20 --batch-timeout 0
Author has addressed the following