Prevent spaces in names #5738
Prevent spaces in names #5738
Conversation
🦋 Changeset detectedLatest commit: 25d04ad The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10581574244/npm-package-wrangler-5738You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5738/npm-package-wrangler-5738Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10581574244/npm-package-wrangler-5738 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10581574244/npm-package-create-cloudflare-5738 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10581574244/npm-package-cloudflare-kv-asset-handler-5738npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10581574244/npm-package-miniflare-5738npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10581574244/npm-package-cloudflare-pages-shared-5738npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10581574244/npm-package-cloudflare-vitest-pool-workers-5738npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10581574244/npm-package-cloudflare-workers-editor-shared-5738npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10581574244/npm-package-cloudflare-workers-shared-5738Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
penalosa
force-pushed
the
4229-bug-websocket-connection-closed-before-connection-established
branch
from
4c19481 to
cdb8e09
Compare
| @@ -236,7 +236,7 @@ export const isString: ValidatorFn = (diagnostics, field, value) => { | |||
| */ | |||
| export const isValidName: ValidatorFn = (diagnostics, field, value) => { | |||
| if ( | |||
| (typeof value === "string" && /^$|^[a-z0-9_ ][a-z0-9-_ ]*$/.test(value)) || | |||
| (typeof value === "string" && /^$|^[a-z0-9_][a-z0-9-_]*$/.test(value)) || | |||
There was a problem hiding this comment.
Change looks good. Maybe a good time to add some unit tests here?
There was a problem hiding this comment.
I've adapted the existing test to ensure it catches this case
| @@ -1123,7 +1123,7 @@ describe("normalizeAndValidateConfig()", () => { | |||
| describe("name", () => { | |||
| it("should error on invalid `name` value with spaces", () => { | |||
| const expectedConfig: RawEnvironment = { | |||
| name: "NCC 1701 D", | |||
There was a problem hiding this comment.
Previously this was tripping the uppercase validation, and so the fact that the spaces validation didn't work was missed
penalosa
deleted the
4229-bug-websocket-connection-closed-before-connection-established
branch
What this PR solves / how to test
Fixes #4229
Author has addressed the following