MQ-605: Extend miniflare's queues simulator to support delayed delivery #5570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ce508b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8999854516/npm-package-wrangler-5570You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5570/npm-package-wrangler-5570Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8999854516/npm-package-wrangler-5570 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8999854516/npm-package-create-cloudflare-5570 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8999854516/npm-package-cloudflare-kv-asset-handler-5570npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8999854516/npm-package-miniflare-5570npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8999854516/npm-package-cloudflare-pages-shared-5570npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8999854516/npm-package-cloudflare-vitest-pool-workers-5570Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
sesteves
force-pushed
the
sesteves/mq-605-support-for-delayed-messages-in-queues
branch
from
a8086d7 to
1d83a86
Compare
penalosa
reviewed
Apr 10, 2024
sesteves
force-pushed
the
sesteves/mq-605-support-for-delayed-messages-in-queues
branch
3 times, most recently
from
1d06b5b to
1832c9e
Compare
penalosa
approved these changes
Apr 23, 2024
|
Approved pending e2e tests (passed, see #5690) |
sesteves
force-pushed
the
sesteves/mq-605-support-for-delayed-messages-in-queues
branch
2 times, most recently
from
5adaca9 to
e98a2c8
Compare
sesteves
force-pushed
the
sesteves/mq-605-support-for-delayed-messages-in-queues
branch
from
e98a2c8 to
ba3ad4a
Compare
petebacondarwin
approved these changes
May 6, 2024
petebacondarwin
requested changes
May 6, 2024
There was a problem hiding this comment.
Actually the change to the configuration API concerns me. We even document it publicly here: https://github.com/cloudflare/workers-sdk/blob/main/packages/miniflare/README.md#queues
sesteves
force-pushed
the
sesteves/mq-605-support-for-delayed-messages-in-queues
branch
from
ba3ad4a to
4ae46ff
Compare
| @@ -311,8 +311,7 @@ test("retries messages", async (t) => { | |||
| const log = new TestLog(t); | |||
| const mf = new Miniflare({ | |||
| log, | |||
|
|
|||
| queueProducers: { QUEUE: "queue" }, | |||
| queueProducers: { QUEUE: { queueName: "queue" } }, | |||
There was a problem hiding this comment.
This change is no longer needed, right?
petebacondarwin
approved these changes
May 7, 2024
sesteves
force-pushed
the
sesteves/mq-605-support-for-delayed-messages-in-queues
branch
2 times, most recently
from
ab34535 to
ee0d6b9
Compare
This patch updates the miniflare's queue broker to support delayed delivery of messages, both when sending the message from a producer and when retrying the message from a consumer. The implementation is based on miniflare's timers, and currently there is no support for specifying the delivery delay in queue settings for a producer.
petebacondarwin
force-pushed
the
sesteves/mq-605-support-for-delayed-messages-in-queues
branch
from
ee0d6b9 to
ce508b7
Compare
Merged
CarmenPopoviciu
added a commit
that referenced
this pull request
Aug 16, 2024
12 tasks
CarmenPopoviciu
added a commit
that referenced
this pull request
Aug 16, 2024
CarmenPopoviciu
added a commit
that referenced
this pull request
Aug 19, 2024
CarmenPopoviciu
added a commit
that referenced
this pull request
Aug 20, 2024
CarmenPopoviciu
added a commit
that referenced
this pull request
Sep 17, 2024
CarmenPopoviciu
added a commit
that referenced
this pull request
Sep 17, 2024
CarmenPopoviciu
added a commit
that referenced
this pull request
Sep 17, 2024
CarmenPopoviciu
added a commit
that referenced
this pull request
Sep 17, 2024
edmundhung
added a commit
that referenced
this pull request
Sep 18, 2024
* fix(miniflare): Fix regression introduced in #5570 * Update .changeset/cool-beans-applaud.md Co-authored-by: Edmund Hung <[email protected]> --------- Co-authored-by: Edmund Hung <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates the miniflare's queue broker to support delayed delivery of messages, both when sending the message from a producer and when retrying the message from a consumer.
The implementation is based on miniflare's timers, and currently there is no support for specifying the delivery delay in queue settings for a producer.
What this PR solves / how to test
Fixes #MQ-605
Author has addressed the following