Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Hello World Python template to c3 #5475

Merged
merged 5 commits into from
Apr 2, 2024
Merged

Add Hello World Python template to c3 #5475

merged 5 commits into from
Apr 2, 2024

Conversation

garrettgu10
Copy link
Contributor

@garrettgu10 garrettgu10 commented Apr 2, 2024

What this PR solves / how to test

This is a remake of #5417 now that I have perms to make a branch instead of a fork. This is to allow the CI runner to see the secrets needed for e2e testing.

Author has addressed the following

@garrettgu10 garrettgu10 requested review from a team as code owners April 2, 2024 15:40
Copy link

changeset-bot bot commented Apr 2, 2024

🦋 Changeset detected

Latest commit: 3c18dcd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.39%. Comparing base (0401db9) to head (3c18dcd).
Report is 33 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #5475      +/-   ##
==========================================
+ Coverage   72.18%   72.39%   +0.20%     
==========================================
  Files         322      329       +7     
  Lines       16663    16976     +313     
  Branches     4260     4324      +64     
==========================================
+ Hits        12029    12290     +261     
- Misses       4634     4686      +52     

see 59 files with indirect coverage changes

Copy link
Contributor

github-actions bot commented Apr 2, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8527638838/npm-package-wrangler-5475

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5475/npm-package-wrangler-5475

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8527638838/npm-package-wrangler-5475 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8527638838/npm-package-create-cloudflare-5475 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8527638838/npm-package-cloudflare-kv-asset-handler-5475
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8527638838/npm-package-miniflare-5475
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8527638838/npm-package-cloudflare-pages-shared-5475
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8527638838/npm-package-cloudflare-vitest-pool-workers-5475

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240329.0
workerd 1.20240329.0 1.20240329.0
workerd --version 1.20240329.0 2024-03-29

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@garrettgu10 garrettgu10 requested a review from jculvey April 2, 2024 16:38
.changeset/long-pears-sell.md Outdated Show resolved Hide resolved
@garrettgu10 garrettgu10 merged commit 80b8fcb into main Apr 2, 2024
25 checks passed
@garrettgu10 garrettgu10 deleted the ggu/c3-python branch April 2, 2024 19:41
@workers-devprod workers-devprod mentioned this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants