-
Notifications
You must be signed in to change notification settings - Fork 782
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[C3] fix: update the remix template url used (as the old one is no longer valid) #5312
Conversation
🦋 Changeset detectedLatest commit: dbba7a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8358287940/npm-package-wrangler-5312 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/5312/npm-package-wrangler-5312 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8358287940/npm-package-wrangler-5312 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8358287940/npm-package-create-cloudflare-5312 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8358287940/npm-package-cloudflare-kv-asset-handler-5312 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8358287940/npm-package-miniflare-5312 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8358287940/npm-package-cloudflare-pages-shared-5312 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/8358287940/npm-package-cloudflare-vitest-pool-workers-5312 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5312 +/- ##
==========================================
+ Coverage 71.66% 71.72% +0.05%
==========================================
Files 313 313
Lines 16230 16230
Branches 4151 4151
==========================================
+ Hits 11632 11641 +9
+ Misses 4598 4589 -9 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What this PR solves / how to test
Remix has renamed their
vite-cloudflare
template tocloudflare
(remix-run/remix#9077)as a result this broke C3's Remix flow, this PR is amending that
Author has addressed the following