Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate constellation commands and add a warning when using the constellation binding #4632

Conversation

G4brym
Copy link
Member

@G4brym G4brym commented Dec 19, 2023

What this PR solves / how to test:
Run wrangler constellation and see the new warning

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because:
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because:
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because:

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@G4brym G4brym requested a review from a team as a code owner December 19, 2023 15:56
Copy link

changeset-bot bot commented Dec 19, 2023

🦋 Changeset detected

Latest commit: a279a39

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 19, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7264538388/npm-package-wrangler-4632

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7264538388/npm-package-wrangler-4632

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7264538388/npm-package-wrangler-4632 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7264538388/npm-package-miniflare-4632
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7264538388/npm-package-cloudflare-pages-shared-4632
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7264538388/npm-package-create-cloudflare-4632 --no-auto-update

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231030.4
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (421cd58) 75.16% compared to head (a279a39) 75.14%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4632      +/-   ##
==========================================
- Coverage   75.16%   75.14%   -0.02%     
==========================================
  Files         242      242              
  Lines       13011    13014       +3     
  Branches     3345     3346       +1     
==========================================
  Hits         9780     9780              
- Misses       3231     3234       +3     
Files Coverage Δ
packages/wrangler/src/constellation/index.ts 100.00% <100.00%> (ø)
packages/wrangler/src/index.ts 89.04% <100.00%> (-0.04%) ⬇️
packages/wrangler/src/dev.tsx 81.81% <50.00%> (-0.26%) ⬇️

... and 2 files with indirect coverage changes

@mrbbot mrbbot merged commit a6a4e8a into cloudflare:main Dec 19, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants