Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C3: Bump to 6.0.3 #4626

Merged
merged 1 commit into from
Dec 19, 2023
Merged

C3: Bump to 6.0.3 #4626

merged 1 commit into from
Dec 19, 2023

Conversation

jculvey
Copy link
Contributor

@jculvey jculvey commented Dec 18, 2023

Fixes #4623.

What this PR solves / how to test:

Author has addressed the following:

Bumps create-svelte to a new major version. This clears up an issue we're seeing where the latest version of @sveltejs/adapter-cloudflare expects the latest major version of sveltekit and fails to install.

  • Tests
    • Included
    • [ x ] Not necessary because: Just a package bump, existing coverage is fine.
  • Changeset (Changeset guidelines)
    • [ x ] Included
    • Not necessary because:
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because:

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@jculvey jculvey requested a review from a team as a code owner December 18, 2023 22:45
Copy link

changeset-bot bot commented Dec 18, 2023

🦋 Changeset detected

Latest commit: 862f7f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7254721784/npm-package-wrangler-4626

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7254721784/npm-package-wrangler-4626

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7254721784/npm-package-wrangler-4626 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7254721784/npm-package-miniflare-4626
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7254721784/npm-package-cloudflare-pages-shared-4626
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7254721784/npm-package-create-cloudflare-4626 --no-auto-update

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231030.4
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Merging #4626 (862f7f2) into main (e2205e3) will decrease coverage by 0.27%.
Report is 7 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4626      +/-   ##
==========================================
- Coverage   75.46%   75.19%   -0.27%     
==========================================
  Files         242      242              
  Lines       12957    13011      +54     
  Branches     3331     3345      +14     
==========================================
+ Hits         9778     9784       +6     
- Misses       3179     3227      +48     

see 11 files with indirect coverage changes

@jculvey jculvey merged commit 421cd58 into main Dec 19, 2023
25 checks passed
@jculvey jculvey deleted the c3-svelte-6-bump branch December 19, 2023 01:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Creating a new SvelteKit project fails
2 participants