Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workers ai usage warning in local mode #4586

Merged
merged 5 commits into from
Dec 11, 2023

Conversation

G4brym
Copy link
Member

@G4brym G4brym commented Dec 11, 2023

What this PR solves / how to test:
Adds workers ai usage warning in local mode. Follow-up to #4522.

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because:
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because:
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because:

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@G4brym G4brym requested a review from a team as a code owner December 11, 2023 17:07
Copy link

changeset-bot bot commented Dec 11, 2023

⚠️ No Changeset found

Latest commit: 66e6c1e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 11, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7171737367/npm-package-wrangler-4586

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7171737367/npm-package-wrangler-4586

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7171737367/npm-package-wrangler-4586 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7171737367/npm-package-miniflare-4586
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7171737367/npm-package-cloudflare-pages-shared-4586
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7171737367/npm-package-create-cloudflare-4586

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231030.3
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #4586 (66e6c1e) into main (3314dbd) will increase coverage by 0.01%.
The diff coverage is 50.00%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4586      +/-   ##
==========================================
+ Coverage   75.54%   75.55%   +0.01%     
==========================================
  Files         242      242              
  Lines       12916    12918       +2     
  Branches     3323     3324       +1     
==========================================
+ Hits         9757     9760       +3     
+ Misses       3159     3158       -1     
Files Coverage Δ
packages/wrangler/src/dev/miniflare.ts 60.47% <50.00%> (+0.38%) ⬆️

... and 4 files with indirect coverage changes

@G4brym
Copy link
Member Author

G4brym commented Dec 11, 2023

@penalosa can you merge the pr, i don't have permissions

@penalosa penalosa merged commit ba9b88f into cloudflare:main Dec 11, 2023
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants