Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip flaky tests #4479

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Skip flaky tests #4479

merged 1 commit into from
Nov 21, 2023

Conversation

penalosa
Copy link
Contributor

Fixes # [insert GH or internal issue number(s)].

What this PR solves / how to test:

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because:
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because:
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because:

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

Copy link

changeset-bot bot commented Nov 21, 2023

⚠️ No Changeset found

Latest commit: d7ecc19

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6947556632/npm-package-wrangler-4479

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6947556632/npm-package-wrangler-4479

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6947556632/npm-package-wrangler-4479 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6947556632/npm-package-miniflare-4479
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6947556632/npm-package-cloudflare-pages-shared-4479

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231030.0
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #4479 (d7ecc19) into main (805d524) will decrease coverage by 0.01%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4479      +/-   ##
==========================================
- Coverage   75.26%   75.26%   -0.01%     
==========================================
  Files         226      226              
  Lines       12559    12559              
  Branches     3258     3258              
==========================================
- Hits         9453     9452       -1     
- Misses       3106     3107       +1     

see 5 files with indirect coverage changes

@penalosa penalosa merged commit dcb1ea6 into main Nov 21, 2023
17 checks passed
@penalosa penalosa deleted the penalosa/skip-flakes branch November 21, 2023 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants