Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused npx-import dependency #4477

Merged
merged 1 commit into from
Nov 23, 2023
Merged

Conversation

dario-piotrowicz
Copy link
Member

I think that the npx-import dependency is not actually used anywhere so I think it's safe to remove it

@dario-piotrowicz dario-piotrowicz requested a review from a team as a code owner November 21, 2023 16:28
Copy link

changeset-bot bot commented Nov 21, 2023

⚠️ No Changeset found

Latest commit: 1d1352d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 21, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6968960920/npm-package-wrangler-4477

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6968960920/npm-package-wrangler-4477

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6968960920/npm-package-wrangler-4477 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6968960920/npm-package-miniflare-4477
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6968960920/npm-package-cloudflare-pages-shared-4477

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231030.1
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Merging #4477 (1d1352d) into main (e6ddf8a) will increase coverage by 0.00%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4477   +/-   ##
=======================================
  Coverage   75.25%   75.26%           
=======================================
  Files         226      226           
  Lines       12570    12570           
  Branches     3261     3261           
=======================================
+ Hits         9460     9461    +1     
+ Misses       3110     3109    -1     

see 4 files with indirect coverage changes

@dario-piotrowicz dario-piotrowicz merged commit 961c8ea into main Nov 23, 2023
17 checks passed
@dario-piotrowicz dario-piotrowicz deleted the remove-npx-import-dep branch November 23, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants