Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hyperdrive] Update validation.ts #4455

Merged
merged 4 commits into from
Nov 17, 2023
Merged

[Hyperdrive] Update validation.ts #4455

merged 4 commits into from
Nov 17, 2023

Conversation

rozenmd
Copy link
Contributor

@rozenmd rozenmd commented Nov 16, 2023

Typo fix and subsequent yak shave

@rozenmd rozenmd requested a review from a team as a code owner November 16, 2023 12:29
Copy link

changeset-bot bot commented Nov 16, 2023

🦋 Changeset detected

Latest commit: f180e49

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 16, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6891036474/npm-package-wrangler-4455

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6891036474/npm-package-wrangler-4455

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6891036474/npm-package-wrangler-4455 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6891036474/npm-package-miniflare-4455
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/6891036474/npm-package-cloudflare-pages-shared-4455

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231025.1
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

Merging #4455 (f180e49) into main (46a35e0) will decrease coverage by 0.01%.
The diff coverage is 92.30%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4455      +/-   ##
==========================================
- Coverage   75.46%   75.46%   -0.01%     
==========================================
  Files         225      225              
  Lines       12478    12482       +4     
  Branches     3239     3242       +3     
==========================================
+ Hits         9417     9420       +3     
- Misses       3061     3062       +1     
Files Coverage Δ
packages/wrangler/src/config/validation.ts 90.10% <100.00%> (+0.01%) ⬆️
...ages/wrangler/src/environment-variables/factory.ts 71.42% <ø> (ø)
packages/wrangler/src/hyperdrive/create.ts 78.78% <100.00%> (ø)
packages/wrangler/src/hyperdrive/delete.ts 100.00% <100.00%> (ø)
packages/wrangler/src/hyperdrive/get.ts 100.00% <100.00%> (ø)
packages/wrangler/src/hyperdrive/index.ts 100.00% <100.00%> (ø)
packages/wrangler/src/hyperdrive/list.ts 100.00% <100.00%> (ø)
packages/wrangler/src/hyperdrive/update.ts 13.79% <100.00%> (ø)
packages/wrangler/src/hyperdrive/utils.ts 80.00% <80.00%> (ø)

@rozenmd rozenmd requested a review from mtlemilio November 16, 2023 12:39
Copy link
Contributor

@elithrar elithrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@a-robinson a-robinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@rozenmd rozenmd merged commit 1747d21 into main Nov 17, 2023
@rozenmd rozenmd deleted the rozenmd-patch-1 branch November 17, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants