Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve listing of queues and update API types #4426

Merged
merged 1 commit into from
Dec 18, 2023

Conversation

OilyLime
Copy link
Contributor

@OilyLime OilyLime commented Nov 10, 2023

Fixes #MQ-410

What this PR solves / how to test:
Improves customer experience when listing queues.

Author has addressed the following:

  • Tests
    • Included
    • Not necessary because:
  • Changeset (Changeset guidelines)
    • Included
    • Not necessary because:
  • Associated docs
    • Issue(s)/PR(s):
    • Not necessary because:

Note for PR author:

We want to celebrate and highlight awesome PR review! If you think this PR received a particularly high-caliber review, please assign it the label highlight pr review so future reviewers can take inspiration and learn from it.

@OilyLime OilyLime requested a review from a team as a code owner November 10, 2023 20:39
Copy link

changeset-bot bot commented Nov 10, 2023

🦋 Changeset detected

Latest commit: ea76239

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
wrangler Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 10, 2023

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7170426614/npm-package-wrangler-4426

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7170426614/npm-package-wrangler-4426

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7170426614/npm-package-wrangler-4426 dev path/to/script.js
Additional artifacts:
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7170426614/npm-package-miniflare-4426
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7170426614/npm-package-cloudflare-pages-shared-4426
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/7170426614/npm-package-create-cloudflare-4426

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20231030.3
workerd 1.20231030.0 1.20231030.0
workerd --version 1.20231030.0 2023-10-30

|

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@OilyLime OilyLime force-pushed the emilio/improve-queues-listing branch from e4c8e1e to ea76239 Compare November 10, 2023 20:46
Copy link
Contributor

@elithrar elithrar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from Queues side.

@penalosa penalosa closed this Dec 11, 2023
@penalosa penalosa reopened this Dec 11, 2023
Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Merging #4426 (ea76239) into main (9bc52cf) will increase coverage by 0.11%.
Report is 83 commits behind head on main.
The diff coverage is 23.52%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4426      +/-   ##
==========================================
+ Coverage   75.47%   75.58%   +0.11%     
==========================================
  Files         225      242      +17     
  Lines       12451    12917     +466     
  Branches     3229     3323      +94     
==========================================
+ Hits         9397     9763     +366     
- Misses       3054     3154     +100     
Files Coverage Δ
packages/wrangler/src/config/validation.ts 90.10% <ø> (+0.01%) ⬆️
packages/wrangler/src/dev/remote.tsx 8.28% <ø> (+0.04%) ⬆️
packages/wrangler/src/https-options.ts 100.00% <100.00%> (ø)
packages/wrangler/src/queues/cli/commands/list.ts 100.00% <100.00%> (ø)
packages/wrangler/src/queues/client.ts 97.29% <ø> (ø)
packages/wrangler/src/dev/proxy.ts 4.51% <7.14%> (-0.07%) ⬇️

... and 42 files with indirect coverage changes

@mrbbot mrbbot merged commit c628de5 into cloudflare:main Dec 18, 2023
28 of 31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants