Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flakey tests #361

Closed
GregBrimble opened this issue Feb 1, 2022 · 2 comments
Closed

Flakey tests #361

GregBrimble opened this issue Feb 1, 2022 · 2 comments
Labels
maintenance Maintenance task

Comments

@GregBrimble
Copy link
Contributor

What version of Wrangler are you using?

N/A

What operating system are you using?

N/A

Describe the Bug

https://github.com/cloudflare/wrangler2/runs/5022637425?check_suite_focus=true

Looks like there's a couple of tests that might be flakey.
@GregBrimble GregBrimble added the maintenance Maintenance task label Feb 1, 2022
@petebacondarwin
Copy link
Contributor

This is because the should offer to install type definitions in an existing typescript project (30003 ms) test is actually running npm install, which in this case ran longer than the 30 secs timeout.
This commit (d499c4d) from my #329 PR will resolve that.

@petebacondarwin petebacondarwin mentioned this issue Feb 1, 2022
Merged
@petebacondarwin
Copy link
Contributor

Closing now that #329 has landed.

GregBrimble pushed a commit that referenced this issue Feb 8, 2024
@dependabot @GregBrimble
chore(deps-dev): bump prettier from 2.8.2 to 2.8.3 (#361)
626b6f7 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
GregBrimble pushed a commit that referenced this issue Feb 9, 2024
@dependabot @GregBrimble
chore(deps-dev): bump prettier from 2.8.2 to 2.8.3 (#361)
f7109b0 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
GregBrimble pushed a commit that referenced this issue Feb 9, 2024
@dependabot @GregBrimble
chore(deps-dev): bump prettier from 2.8.2 to 2.8.3 (#361)
ddd8184 
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Feb 10, 2024
Open
Open
Open
Open
Open
Open
This was referenced Feb 17, 2024
Open
Open
Open
Open
Open
Open
Open
This was referenced Feb 25, 2024
Open
Open
Open
Open
Open
This was referenced Mar 4, 2024
Open
Open
Open
Open
This was referenced Mar 7, 2024
Open
Open
Open
Open
Open
Open
Open
This was referenced Mar 15, 2024
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Mar 22, 2024
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
maintenance Maintenance task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@petebacondarwin @GregBrimble