Fix Quick Edit and Devtools builds (#3864)

cloudflare · Aug 29, 2023 · c8f1e5f · c8f1e5f
1 parent abfdbb4
commit c8f1e5f
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 8 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/quick-edit-extension/scripts/bundle.ts b/packages/quick-edit-extension/scripts/bundle.ts
@@ -7,7 +7,6 @@ type BuildFlags = {
 
 async function buildMain(flags: BuildFlags = {}) {
 	const options: esbuild.BuildOptions = {
-		watch: flags.watch,
 		entryPoints: ["./src/extension.ts"],
 		bundle: true,
 		outfile: "./dist/extension.js",
@@ -40,7 +39,12 @@ async function buildMain(flags: BuildFlags = {}) {
 			},
 		],
 	};
-	await esbuild.build(options);
+	if (flags.watch) {
+		const ctx = await esbuild.context(options);
+		await ctx.watch();
+	} else {
+		await esbuild.build(options);
+	}
 }
 
 async function run() {

diff --git a/packages/wrangler-devtools/Makefile b/packages/wrangler-devtools/Makefile
@@ -20,10 +20,7 @@ devtools-frontend/out/Default/gen/front_end: devtools-frontend
 	cd devtools-frontend && PATH=$(PATH_WITH_DEPOT) $(ROOT)/depot/gn gen out/Default
 	cd devtools-frontend && PATH=$(PATH_WITH_DEPOT) $(ROOT)/depot/autoninja -C out/Default
 
-node_modules:
-	npm ci
-
-publish: node_modules devtools-frontend/out/Default/gen/front_end
+publish: devtools-frontend/out/Default/gen/front_end
 	npx wrangler pages deploy --project-name cloudflare-devtools devtools-frontend/out/Default/gen/front_end
 
 cleanup: