only proxy consoleAPICalled events in remote mode

cloudflare · Nov 8, 2023 · a49cc8a · a49cc8a
1 parent fc983ad
commit a49cc8a
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 3 deletions.
diff --git a/packages/wrangler/src/api/startDevWorker/ProxyController.ts b/packages/wrangler/src/api/startDevWorker/ProxyController.ts
@@ -328,14 +328,19 @@ export class ProxyController extends EventEmitter {
 		this.latestConfig = data.config;
 		this.latestBundle = data.bundle;
 
+		const proxyData = {
+			proxyLogsToController: data.config.dev?.remote, // in local mode, workerd logs to terminal directly
+			...data.proxyData,
+		};
+
 		void this.sendMessageToProxyWorker({
 			type: "play",
-			proxyData: data.proxyData,
+			proxyData,
 		});
 
 		void this.sendMessageToInspectorProxyWorker({
 			type: "reloadComplete",
-			proxyData: data.proxyData,
+			proxyData,
 		});
 	}
 	onProxyWorkerMessage(message: ProxyWorkerOutgoingRequestBody) {

diff --git a/packages/wrangler/src/api/startDevWorker/events.ts b/packages/wrangler/src/api/startDevWorker/events.ts
@@ -138,4 +138,5 @@ export type ProxyData = {
 	userWorkerInnerUrlOverrides: Partial<UrlOriginParts>;
 	headers: Record<string, string>;
 	liveReload?: boolean;
+	proxyLogsToController?: boolean;
 };
diff --git a/packages/wrangler/templates/startDevWorker/InspectorProxyWorker.ts b/packages/wrangler/templates/startDevWorker/InspectorProxyWorker.ts
@@ -208,8 +208,11 @@ export class InspectorProxyWorker implements DurableObject {
 			| DevToolsEvents;
 		this.sendDebugLog("RUNTIME INCOMING MESSAGE", msg);
 
+		if (isDevToolsEvent(msg, "Runtime.exceptionThrown")) {
+			this.sendProxyControllerMessage(event.data);
+		}
 		if (
-			isDevToolsEvent(msg, "Runtime.exceptionThrown") ||
+			this.proxyData?.proxyLogsToController &&
 			isDevToolsEvent(msg, "Runtime.consoleAPICalled")
 		) {
 			this.sendProxyControllerMessage(event.data);