prefix all boolean event properties with "is"

packages/create-cloudflare/src/event.ts

@@ -470,12 +470,12 @@ export type Event =
 				/**
 				 * Whether the user was already logged in before running the CLI
 				 */
-				alreadyLoggedIn?: boolean;
+				isAlreadyLoggedIn?: boolean;
 
 				/**
 				 * Whether the user successfully going through the login process if they were not already logged in
 				 */
-				newLoginSuccessful?: boolean;
+				isLoginSuccessful?: boolean;
 
 				/**
 				 * The duration of the prompt since it started in milliseconds (ms)
@@ -526,12 +526,12 @@ export type Event =
 				/**
 				 * Whether the user was already logged in before running the CLI
 				 */
-				alreadyLoggedIn?: boolean;
+				isAlreadyLoggedIn?: boolean;
 
 				/**
 				 * Whether the user successfully going through the login process if they were not already logged in
 				 */
-				newLoginSuccessful?: boolean;
+				isLoginSuccessful?: boolean;
 
 				/**
 				 * The error that caused the session to be crashed
@@ -590,12 +590,12 @@ export type Event =
 				/**
 				 * Whether the user was already logged in before running the CLI
 				 */
-				alreadyLoggedIn?: boolean;
+				isAlreadyLoggedIn?: boolean;
 
 				/**
 				 * Whether the user successfully going through the login process if they were not already logged in
 				 */
-				newLoginSuccessful?: boolean;
+				isLoginSuccessful?: boolean;
 
 				/**
 				 * The duration of the prompt since it started in milliseconds (ms)

packages/create-cloudflare/src/metrics.ts

@@ -16,6 +16,9 @@ import type { Event } from "./event";
 type EventPrefix<Suffix extends string> =
 	Event["name"] extends `${infer Name} ${Suffix}` ? Name : never;
 
+// A type to get all possible keys of a union type
+type KeysOfUnion<Obj> = Obj extends Obj ? keyof Obj : never;
+
 // A type to extract the properties of an event based on the name
 type EventProperties<EventName extends Event["name"]> = Extract<
 	Event,
@@ -222,7 +225,10 @@ export function createReporter() {
 	}
 
 	// To be used within `collectAsyncMetrics` to update the properties object sent to sparrow
-	function setEventProperty(key: string, value: unknown) {
+	function setEventProperty<Key extends KeysOfUnion<Event["properties"]>>(
+		key: Key,
+		value: unknown,
+	) {
 		const store = als.getStore();
 
 		// Throw only on test environment to avoid breaking the CLI

packages/create-cloudflare/src/wrangler/accounts.ts

@@ -60,12 +60,12 @@ export const wranglerLogin = async (ctx: C3Context) => {
 			s.start(
 				`Logging into Cloudflare ${dim("checking authentication status")}`,
 			);
-			const alreadyLoggedIn = await isLoggedIn();
-			s.stop(brandColor(alreadyLoggedIn ? "logged in" : "not logged in"));
+			const isAlreadyLoggedIn = await isLoggedIn();
+			s.stop(brandColor(isAlreadyLoggedIn ? "logged in" : "not logged in"));
 
-			reporter.setEventProperty("alreadyLoggedIn", alreadyLoggedIn);
+			reporter.setEventProperty("isAlreadyLoggedIn", isAlreadyLoggedIn);
 
-			if (alreadyLoggedIn) {
+			if (isAlreadyLoggedIn) {
 				return true;
 			}
 
@@ -83,7 +83,7 @@ export const wranglerLogin = async (ctx: C3Context) => {
 			const verb = success ? "allowed" : "denied";
 			s.stop(`${brandColor(verb)} ${dim("via `wrangler login`")}`);
 
-			reporter.setEventProperty("newLoginSuccessful", success);
+			reporter.setEventProperty("isLoginSuccessful", success);
 
 			return success;
 		},