Add derive debug, clone for FormData and File #395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dev-ardi
force-pushed
the
derive-debug-clone
branch
3 times, most recently
from
32825eb
to
7494fe3
Compare
|
I've added a few more |
dev-ardi
force-pushed
the
derive-debug-clone
branch
from
cbd54e3
to
025e28f
Compare
zebp
requested changes
Nov 9, 2023
| @@ -182,10 +183,3 @@ impl From<Headers> for HeaderMap { | |||
| (&headers).into() | |||
| } | |||
| } | |||
|
|
|||
| impl Clone for Headers { | |||
There was a problem hiding this comment.
We can't use the derive-based clone implementation here as we do an explicit call to web_sys::Headers::new_with_headers because the inner JS headers are sometimes immutable. The derive clone will just clone a reference to those potentially immutable headers where-as the explicit clone will perform a deep copy.
There was a problem hiding this comment.
I won't use workers anymore, feel free to close this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds derive macros for a couple of types. There's no reason not to have them.