Skip to content

Commit

Permalink
disabling all precommit hooks that depend on external binaries (#2785)
Browse files Browse the repository at this point in the history
This got out of hand and many developers report problems.
All third-party dependencies need to be fetched by bazel
if they are a requirement for workerd development.

Feel free to uncomment particular formatters once dependency management is fixed.

This is not a reflection on linters/formatters at all: they are super useful and we should continue increasing the coverage.
  • Loading branch information
mikea authored Sep 24, 2024
1 parent c226a56 commit d58d1d0
Showing 1 changed file with 15 additions and 15 deletions.
30 changes: 15 additions & 15 deletions tools/cross/format.py
Original file line number Diff line number Diff line change
Expand Up @@ -186,21 +186,21 @@ class FormatConfig:


FORMATTERS = [
FormatConfig(
directory="src/workerd", globs=("*.c++", "*.h"), formatter=clang_format
),
FormatConfig(
directory="src",
globs=("*.js", "*.ts", "*.cjs", "*.ejs", "*.mjs"),
formatter=prettier,
),
FormatConfig(directory="src", globs=("*.json",), formatter=prettier),
FormatConfig(directory=".", globs=("*.py",), formatter=ruff),
FormatConfig(
directory=".",
globs=("*.bzl", "WORKSPACE", "BUILD", "BUILD.*"),
formatter=buildifier,
),
# FormatConfig(
# directory="src/workerd", globs=("*.c++", "*.h"), formatter=clang_format
# ),
# FormatConfig(
# directory="src",
# globs=("*.js", "*.ts", "*.cjs", "*.ejs", "*.mjs"),
# formatter=prettier,
# ),
# FormatConfig(directory="src", globs=("*.json",), formatter=prettier),
# FormatConfig(directory=".", globs=("*.py",), formatter=ruff),
# FormatConfig(
# directory=".",
# globs=("*.bzl", "WORKSPACE", "BUILD", "BUILD.*"),
# formatter=buildifier,
# ),
]


Expand Down

0 comments on commit d58d1d0

Please sign in to comment.