CI fixes #928
Merged
CI fixes #928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacobbednarz
commented
Feb 1, 2021
| @@ -10,6 +11,58 @@ import ( | |||
| "github.com/hashicorp/terraform-plugin-sdk/terraform" | |||
| ) | |||
|
|
|||
| func init() { | |||
There was a problem hiding this comment.
jacobbednarz
commented
Feb 1, 2021
| @@ -597,7 +597,7 @@ func TransformAccessGroupForSchema(accessGroup []interface{}) []map[string]inter | |||
| gsuiteCfg := groupValue.(map[string]interface{}) | |||
| gsuiteID = gsuiteCfg["identity_provider_id"].(string) | |||
| gsuiteEmails = append(gsuiteEmails, gsuiteCfg["name"].(string)) | |||
| case "github": | |||
| case "github-organization": | |||
There was a problem hiding this comment.
jacobbednarz
commented
Feb 1, 2021
| @@ -235,7 +235,7 @@ func testAccessPolicyGroupConfig(resourceID, zone, accountID string) string { | |||
| name = "%[1]s" | |||
|
|
|||
| include { | |||
| ip = ["127.0.0.1"] | |||
| ip = ["127.0.0.1/32"] | |||
There was a problem hiding this comment.
jacobbednarz
commented
Feb 1, 2021
| @@ -10,6 +11,42 @@ import ( | |||
| "github.com/hashicorp/terraform-plugin-sdk/terraform" | |||
| ) | |||
|
|
|||
| func init() { | |||
There was a problem hiding this comment.
This was referenced May 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gets the CI runs for acceptance tests closer to a fully green run.
github=>github-organization(follow up from Correctly handle Access Group schema transformations #917/resource/access_group: pass group conditions viaTransformAccessGroupForSchema#918)cloudflare_authenticated_origin_pulls_certificateto make sure we are only testing the managed resources