Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing 'firewall_events' dataset to cloudflare_logpush_job. #660

Merged
merged 1 commit into from
Apr 19, 2020
+2 −2
Merged

Add missing 'firewall_events' dataset to cloudflare_logpush_job. #660

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cloudflare/resource_cloudflare_logpush_job.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ func resourceCloudflareLogpushJob() *schema.Resource {
"dataset": {
Type: schema.TypeString,
Required: true,
ValidateFunc: validation.StringInSlice([]string{"http_requests", "spectrum_events"}, false),
ValidateFunc: validation.StringInSlice([]string{"firewall_events", "http_requests", "spectrum_events"}, false),
},
"logpull_options": {
Type: schema.TypeString,
Expand Down
2 changes: 1 addition & 1 deletion website/docs/r/logpush_job.html.markdown
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,6 @@ The following arguments are supported:
* `zone_id` - (Required) The zone ID where the logpush job should be created.
* `destination_conf` - (Required) Uniquely identifies a resource (such as an s3 bucket) where data will be pushed. Additional configuration parameters supported by the destination may be included. See [Logpush destination documentation](https://developers.cloudflare.com/logs/logpush/logpush-configuration-api/understanding-logpush-api/#destination).
* `ownership_challenge` - (Required) Ownership challenge token to prove destination ownership. See [Developer documentation](https://developers.cloudflare.com/logs/logpush/logpush-configuration-api/understanding-logpush-api/#usage).
* `dataset` - (Required) Which type of dataset resource to use. Available values are `"http_requests"` or `"spectrum_events"`.
* `dataset` - (Required) Which type of dataset resource to use. Available values are `"firewall_events"`, `"http_requests"`, and `"spectrum_events"`.
* `logpull_options` - (Optional) Configuration string for the Logshare API. It specifies things like requested fields and timestamp formats. See [Logpull options documentation](https://developers.cloudflare.com/logs/logpush/logpush-configuration-api/understanding-logpush-api/#options).
* `enable` - (Optional) Whether to enable to job to create or not.