add support for changing traffic type in spectrum apps #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patryk
requested changes
Sep 28, 2019
| @@ -20,6 +20,7 @@ type SpectrumApplication struct { | |||
| IPFirewall bool `json:"ip_firewall,omitempty"` | |||
| ProxyProtocol bool `json:"proxy_protocol,omitempty"` | |||
| TLS string `json:"tls,omitempty"` | |||
| TrafficType string `json:"traffic_type,omitempty"` | |||
There was a problem hiding this comment.
Please PR this in https://github.com/cloudflare/cloudflare-go/blob/master/spectrum.go
We'll vendor the change back here in separate PR.
There was a problem hiding this comment.
| Default: "tcp", | ||
| Optional: true, | ||
| ValidateFunc: validation.StringInSlice([]string{ | ||
| "tcp", "http", "https", |
There was a problem hiding this comment.
Valid values are: direct, http, https
https://api.cloudflare.com/#spectrum-applications-properties
|
Please add new field to docs. |
8 tasks
gposton
force-pushed
the
master
branch
2 times, most recently
from
e10e8ca to
9666435
Compare
ghost
added
the
kind/documentation
Done! |
patryk
approved these changes
Oct 1, 2019
|
Great, thanks @gposton ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR needs merged and vendored in prior to merging this: cloudflare/cloudflare-go#350