fix: add SSL.com as valid certificate authority for cloudflare_certificate_pack #4267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
changelog detected ✅ |
jacobbednarz
requested changes
Oct 10, 2024
| @@ -50,7 +50,7 @@ func resourceCloudflareCertificatePackSchema() map[string]*schema.Schema { | |||
| Type: schema.TypeString, | |||
| Required: true, | |||
| ForceNew: true, | |||
| ValidateFunc: validation.StringInSlice([]string{"digicert", "lets_encrypt", "google"}, false), | |||
| ValidateFunc: validation.StringInSlice([]string{"digicert", "lets_encrypt", "google", ssl_com"}, false), | |||
| Default: nil, | |||
| Description: fmt.Sprintf("Which certificate authority to issue the certificate pack. %s", renderAvailableDocumentationValuesStringSlice([]string{"digicert", "lets_encrypt", "google"})), | |||
There was a problem hiding this comment.
we also should put the value here in the description and run the docs generation to pick up on it.
There was a problem hiding this comment.
Thanks for pointing that out. Ran make docs and some other changes were picked up. Is ok to include them or should we leave those out ?
|
This functionality has been released in v4.44.0 of the Terraform Cloudflare Provider. Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading. For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Add
ssl_comto the slice containing valid certificate authorities that can be used to manage acloudflare_certificate_packresourceWhy
ssl_comin the API endpoint that lists certificate packs