Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AUTH-5608 fixed bug on update access application always sending allow… #3140

Merged
merged 4 commits into from
Feb 27, 2024
Merged

AUTH-5608 fixed bug on update access application always sending allow… #3140

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
49f32e4
AUTH-5608 fixed bug on update access application always sending allow…
rkernscloudflaretest Feb 23, 2024
094b54f
Merge branch 'master' into rkerns/AUTH-5608_update_bug
jacobbednarz Feb 26, 2024
7fc4404
Merge branch 'master' into rkerns/AUTH-5608_update_bug
jacobbednarz Feb 26, 2024
2307611
Merge branch 'master' into rkerns/AUTH-5608_update_bug
jacobbednarz Feb 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .changelog/3140.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
```release-note:bug
resource/cloudflare_access_application: Fix issue with sending allow_authenticate_via_warp on updates when it is not provided
```
5 changes: 4 additions & 1 deletion internal/sdkv2provider/resource_cloudflare_access_application.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,10 @@ func resourceCloudflareAccessApplicationUpdate(ctx context.Context, d *schema.Re
SkipInterstitial: cloudflare.BoolPtr(d.Get("skip_interstitial").(bool)),
AppLauncherVisible: cloudflare.BoolPtr(d.Get("app_launcher_visible").(bool)),
ServiceAuth401Redirect: cloudflare.BoolPtr(d.Get("service_auth_401_redirect").(bool)),
AllowAuthenticateViaWarp: cloudflare.BoolPtr(d.Get("allow_authenticate_via_warp").(bool)),
}

if _, ok := d.GetOk("allow_authenticate_via_warp"); ok {
updatedAccessApplication.AllowAuthenticateViaWarp = cloudflare.BoolPtr(d.Get("allow_authenticate_via_warp").(bool))
}

if appType != "saas" {
Expand Down
Loading