Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make requests_to_origin have a default value #2954

Merged
merged 2 commits into from
Nov 22, 2023
Merged

Make requests_to_origin have a default value #2954

merged 2 commits into from
Nov 22, 2023

Conversation

tamas-jozsa
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 21, 2023 •
edited
Loading

changelog detected ✅

@tamas-jozsa tamas-jozsa force-pushed the default-requests-to-origin branch from 367e98f to c962145 Compare November 21, 2023 09:20
@jacobbednarz
Copy link
Member

acceptance tests look good

TF_ACC=1 go test ./internal/framework/service/rulesets -v -run "^TestAccCloudflareRuleset_RateLimit" -count 1 -timeout 120m -parallel 1
=== RUN   TestAccCloudflareRuleset_RateLimit
--- PASS: TestAccCloudflareRuleset_RateLimit (14.75s)
=== RUN   TestAccCloudflareRuleset_RateLimitScorePerPeriod
--- PASS: TestAccCloudflareRuleset_RateLimitScorePerPeriod (9.66s)
=== RUN   TestAccCloudflareRuleset_RateLimitMitigationTimeoutOfZero
=== PAUSE TestAccCloudflareRuleset_RateLimitMitigationTimeoutOfZero
=== CONT  TestAccCloudflareRuleset_RateLimitMitigationTimeoutOfZero
--- PASS: TestAccCloudflareRuleset_RateLimitMitigationTimeoutOfZero (10.68s)
PASS
ok  	github.com/cloudflare/terraform-provider-cloudflare/internal/framework/service/rulesets	36.373s

manual testing locally also has this looking good.

@jacobbednarz jacobbednarz merged commit 8f08efa into cloudflare:master Nov 22, 2023
9 checks passed
@github-actions github-actions bot added this to the v4.20.0 milestone Nov 22, 2023
github-actions bot pushed a commit that referenced this pull request Nov 22, 2023
Update CHANGELOG.md for #2954
8ea3d0e
@github-actions GitHub Actions
Copy link
Contributor

This functionality has been released in v4.20.0 of the Terraform Cloudflare Provider.

Please see the Terraform documentation on provider versioning or reach out if you need any assistance upgrading.

For further feature requests or bug reports with this functionality, please create a new GitHub issue following the template. Thank you!

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacobbednarz jacobbednarz Awaiting requested review from jacobbednarz jacobbednarz is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v4.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tamas-jozsa @jacobbednarz